Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exo_buffering is not showing when playWhenReady is false #4445

Closed
ThomasWilliamMarsh opened this issue Jun 28, 2018 · 1 comment
Closed

exo_buffering is not showing when playWhenReady is false #4445

ThomasWilliamMarsh opened this issue Jun 28, 2018 · 1 comment
Assignees

Comments

@ThomasWilliamMarsh
Copy link

ThomasWilliamMarsh commented Jun 28, 2018

Hey guys,

when determining if the buffering logo should show, we have the following condition:

      boolean showBufferingSpinner =
          showBuffering
              && player != null
              && player.getPlaybackState() == Player.STATE_BUFFERING
              && player.getPlayWhenReady();

Why are we checking if playWhenReady is set to true? in the case of the video being paused, and the user scrubs the timeline to another point, the buffering logo is not showing, although it is buffering. Should we not remove this?

@ThomasWilliamMarsh ThomasWilliamMarsh changed the title exo_buffering is not show showing when playWhenReady is false exo_buffering is not showing when playWhenReady is false Jun 28, 2018
@ojw28
Copy link
Contributor

ojw28 commented Jun 28, 2018

Duplicate of #4304

@ojw28 ojw28 marked this as a duplicate of #4304 Jun 28, 2018
@ojw28 ojw28 closed this as completed Jun 28, 2018
@ojw28 ojw28 self-assigned this Jun 28, 2018
@google google locked and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants