Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support seeking in AAC #4548

Closed
satyres opened this issue Jul 22, 2018 · 10 comments
Closed

Support seeking in AAC #4548

satyres opened this issue Jul 22, 2018 · 10 comments
Assignees

Comments

@satyres
Copy link

satyres commented Jul 22, 2018

Hi , i've tried to seek into AAC files but they won't
Please is there a way to let AAC file seekable.
Can you add this option in the futur ?
Thanks

@ojw28 ojw28 changed the title AAC file not seekable . Support seeking in AAC Jul 22, 2018
@ojw28
Copy link
Contributor

ojw28 commented Jul 22, 2018

We may add approximate seeking using a constant bitrate assumption, at some point in the future.

That said, if you need seeking, you should really be using a container format that's better able to support it (e.g. MP4).

@satyres
Copy link
Author

satyres commented Jul 23, 2018

Thanks so much for your answer.
Can you tell me how to put it in MP4 container ?
by the way , ts file (from HLS streams) won't play using Exoplayer aswell (local file not stream)
Best regards

@ojw28
Copy link
Contributor

ojw28 commented Aug 6, 2018

Approximate seeking is now supported in the dev-v2 branch, if you specify the FLAG_ENABLE_CONSTANT_BITRATE_SEEKING whe constructing an AdtsExtractor.

Can you tell me how to put it in MP4 container ?

Advising on how to prepare content is beyond the scope of this issue tracker. Tools such as ffmpeg and mp4box probably help with this.

@ojw28 ojw28 closed this as completed Aug 6, 2018
@satyres
Copy link
Author

satyres commented Aug 8, 2018

Hi , Thanks ojw28 , so Seeking will be available in the next release ?
Thanks

@ojw28
Copy link
Contributor

ojw28 commented Aug 8, 2018

It will be available in 2.9.0 (which may or may not be the next release, depending on whether there's a 2.8.4).

@satyres
Copy link
Author

satyres commented Aug 8, 2018

Thanks so much ojw28 for your time.
Have a nice day.
Best regards

@satyres
Copy link
Author

satyres commented Dec 3, 2018

Hi , Thanks for all your work
but the problem for AAC has not been fixed.
the duration and seeking are not working.
in 2.9.0 and 2.9.2
please is there something we can do ?
Regards

@ojw28
Copy link
Contributor

ojw28 commented Dec 3, 2018

Are you using the FLAG_ENABLE_CONSTANT_BITRATE_SEEKING as mentioned as being required further up this thread? Please see this faq for information on how to use it.

I'm not going to re-open this issue because it does not contain the information requested in the issue template (e.g. a sample file so we know exactly what type of media you're playing). If you're using the flag and this is still a problem, I'd suggest filing a new issue where you fill in the issue template completely. Thanks.

@satyres
Copy link
Author

satyres commented Dec 6, 2018

Hi ojw28,
Thanks so much for your reply.
enabling FLAG_ENABLE_CONSTANT_BITRATE_SEEKING did it , and it's working.
but not on all AAC files ,if you want i will send you a file to test on it.
Best regards

@ojw28
Copy link
Contributor

ojw28 commented Dec 9, 2018

Please send a test file to dev.exoplayer@gmail.com, and respond here to indicate that you've done so. Thanks!

@google google locked and limited conversation to collaborators Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants