-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate discontinuity reason for ad skipping #4768
Comments
You can query the ad group positions by getting the timeline period with If the ad is currently playing, you can also check |
Thanks but... and 'period' in version 2.8.4 does not have a method or variable 'adPlaybackState' can you give me some more info on why I have the exception? |
The information is not available immediately but only after the ad data has been loaded. Please listen to Sorry for the |
Thanks for the directions. is it an error or can I always consider -1 a post-roll? |
That shouldn't be the case. Are you sure the post-roll is still playing? |
in fact player.isPlayingAd () returns false, I tried to insert the logic both in "onTimelineChanged" and in "VideoAdPlayer.VideoAdPlayerCallback - onPlay" but in the case of post-roll I always have player.isPlayingAd() false. What is the best callback to track the transition from an advertisement to content and vice-versa? |
You need to listen to |
I was also trying 'onPositionDiscontinuity' but it seems to me that it is not always called, while 'onTracksChanged' is called regularly between an ad and the content and vice-versa |
|
onPositionDiscontinuity - DISCONTINUITY_REASON_AD_INSERTION is not called when I skip the ad |
Yes indeed. As noted above, the transition can also happen as part of a Admittedly, this is really confusing and I was expecting to receive the onPositionDiscontinuity too in this case. Will have a look whether we should report DISCONTINUITY_REASON_AD_INSERTION as well in such a case. Marking it as an enhancement. |
This commit that landed in dev-v2 deprecates the old This is relevant for detecting discontinuities that involve ads in the following:
|
Is there a method in ima-extensions to know if the ad in playback is a pre-roll, mid-roll or post-roll?
Thanks
The text was updated successfully, but these errors were encountered: