Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPAD ui navigation - dispatchKeyEvent doesn't reset the timer for hiding player controller #5963

Closed
sviety opened this issue May 29, 2019 · 1 comment
Assignees
Labels

Comments

@sviety
Copy link

sviety commented May 29, 2019

[REQUIRED] Issue description

I'm updating exoplayer version in my TV application from 2.6 to the newer version (2.9+) and i noticed that during navigation using DPAD PlaybackControlView auto hide timer is not being reset on key events.
Older version (2.6) was working properly - PlaybackControlView was being hiden after few moments since last KeyEvent. I'm using simmilar implementation as demo applcation for handling key events, so the dispatchKeyEvent method in Activity is handled in a same fashion.

[REQUIRED] Reproduction steps

Use demo application on devices with AndroidTV and use DPAD to navigate on player components.

[REQUIRED] Link to test content

N/A

[REQUIRED] A full bug report captured from the device

N/A

[REQUIRED] Version of ExoPlayer being used

2.10.1 and 2.9.2

[REQUIRED] Device(s) and version(s) of Android being used

Xiami MI BOX Android 8.0
emulator Android TV 8.0

@ojw28
Copy link
Contributor

ojw28 commented May 31, 2019

Fixed by 6e70124.

@ojw28 ojw28 closed this as completed May 31, 2019
@google google locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants