Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP3 stream stops playing after audio ad #6315

Closed
dim4ikhot opened this issue Aug 19, 2019 · 1 comment
Closed

MP3 stream stops playing after audio ad #6315

dim4ikhot opened this issue Aug 19, 2019 · 1 comment

Comments

@dim4ikhot
Copy link

Hi,
I know that a similar question already was asked before(#5658), but now it closed, but the issue is still exists. But in my case all the time I press PLAY, stream plays an audio ad and stops, so I cannot play the stream. I'm using the latest version of Exoplayer - 2.10.4. But the interesting thing is that this stream was working well with version r2.4.3.

2.10.4 returns Player.STATE_ENDED after audio ad finished playback, where r2.4.3 just continued playing.

Here is the stream for where I reproduced an issue:
http://198.143.144.226:8277/

Thanks for any help.

Bests,
Dmitriy

@tonihei
Copy link
Collaborator

tonihei commented Aug 20, 2019

As you pointed out, this stream has the same problem as the one in #5658 .

The content producer just glued together two mp3 files which are incompatible:

  1. The ad with a seek map for the first 9 seconds.
  2. The unseekable live stream.

To solve this issue, the stream should either provide a full XING seek map for the entire duration or shouldn't publish a seek map at all.

It used to "work" up until version 2.9. because we just continued playing even if the official duration has already been reached. This is not really the right approach because we can easily end up reading unrelated garbage data at the end of file as reported in #4954

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants