Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerNotificationManager icon state when player is in STATE_ENDED #6324

Closed
abouda opened this issue Aug 20, 2019 · 3 comments
Closed

PlayerNotificationManager icon state when player is in STATE_ENDED #6324

abouda opened this issue Aug 20, 2019 · 3 comments
Assignees
Labels

Comments

@abouda
Copy link

abouda commented Aug 20, 2019

[REQUIRED] Issue description

Using com.google.android.exoplayer2.ui.PlayerNotificationManager, when ExoPlayer's state changes to STATE_ENDED, the pause icon in the notification does not change to play. (It does change in the expanded notification).

[REQUIRED] Reproduction steps

  • Start playing a stream
  • Wait for ExoPlayer to reach end (STATE_ENDED)
  • Check the notification

[REQUIRED] Link to test content

Any content that can end.

[REQUIRED] A full bug report captured from the device

No bug report since it is a UI issue.

[REQUIRED] Version of ExoPlayer being used

2.10.4

[REQUIRED] Device(s) and version(s) of Android being used

Tested on Emulators and devices. Android versions 7/8/9.

player-ended-notification

@tonihei
Copy link
Collaborator

tonihei commented Aug 23, 2019

@marcbaechinger Can you take a look?

@ojw28
Copy link
Contributor

ojw28 commented Aug 27, 2019

I think PlayerNotificationManager.getActionIndicesForCompactView needs to use isPlaying() to decide which action to display, rather than playWhenReady.

@ojw28
Copy link
Contributor

ojw28 commented Sep 10, 2019

Fixed in eedf50f

@ojw28 ojw28 closed this as completed Sep 10, 2019
@google google locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants