Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAC primer support from audios made from iOS aac encoder #89

Closed
edisonw opened this issue Oct 23, 2014 · 2 comments
Closed

AAC primer support from audios made from iOS aac encoder #89

edisonw opened this issue Oct 23, 2014 · 2 comments

Comments

@edisonw
Copy link

edisonw commented Oct 23, 2014

The iOS aac encoder inserts unnecessary silent frames that needs to be dropped at decoding phase: https://developer.apple.com/library/ios/technotes/tn2258/_index.html Silent detection will be needed in this case.

@edisonw edisonw changed the title iOS video support AAC primer support from audios made from iOS aac encoder Oct 23, 2014
@ojw28
Copy link
Contributor

ojw28 commented Oct 26, 2014

I'm confused about what the actual bug is here. What happens if you don't drop them? I don't think you can just drop silence from the start, since there can be legitimate silence at the start that you don't want to drop.

@edisonw
Copy link
Author

edisonw commented Oct 27, 2014

" I don't think you can just drop silence from the start, since there can be legitimate silence at the start that you don't want to drop." agree, tried it and it breaks some videos. I guess this is only a problem if you are trying to playback a series of those videos, in that case you can't achieve gapless playback between the files (or if you try to loop it to the front), there will always be a small audio gap.

@ojw28 ojw28 closed this as completed Oct 30, 2014
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants