-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out forced subtitle tracks from StyledPlayerControlView text track selector #9432
Comments
I think it's important to separate the player's track selection logic from what tracks are shown in a UI track selector.
When you pick a specific track in the track selection UI, the So can you please clarify:
This doesn't look surprising, tracks are mapped to renderers whether they're enabled or disabled. Which track(s) of that mapping that are selected for playback is stored in a |
The first one, however, the subtitles are retrieved during Widevine playback, e.g., one of the subtitles that needs to be filtered, shown here is labeled German (Germany) (Forced).
I've been using
I have sent the media info I've been using to test this. Thank you for your help. |
This isn't a UI component. From the screenshot it looks like you're using
Thanks for the stream. The DRM license doesn't seem to work [1], but I think that's OK because I can still see all the track info for the text tracks without it. I think there are two separate things going on here:
For (1): Assigning to @ojw28 to decide a sensible default behaviour here. I think it probably does make sense to always filter out forced subtitle tracks from the menu triggered by For (2): If your media uses the [1]
|
Agreed. The change to |
@icbaker Yes, sorry I am using @ojw28 In the meantime, would I need to try customizing or overriding Thank you guys for getting to the bottom of this. |
It's not something you can solve with layout files. You would probably need to fork |
Note: We should also remove references to "Auto" and just show which track is selected. |
@ojw28 when no text tracks are selected shouldn't the |
@SaurabhOfficial Please file a new issue with the info requested in the template (media we can use to reproduce the issue, and a bug report taken after reproducing in the demo app). |
@ojw28 Do we want to show the name even if it's a 'forced' track? It seems perhaps a user shouldn't even 'know' that a forced track is selected, since it's assumed to be required to understand the content of a given audio track. |
That sounds right. I think the UI should show CC as "off" or "none", but the forced track should still be selected. |
I have DASH video files containing closed captions links within the mpd file, so I'm not manually adding subtitles. Some video assets have Forced language captions that I don't want to show in the player (which is showing up twice). For example, French, German, and Spanish forced should be excluded in options user can select:
French (Parisian) (Forced)
German (Germany) (Forced)
Spanish (Castilian) (Forced)
French (Parisian) (Full)
German (Germany) (Full)
Spanish (Castilian) (Full)
Marathi (Full)
Norwegian (Full)
Danish (Full)
Turkish (Full)
I'm using the default StyledPlayerView, and have tried something along the lines of
but with no success. I'm able to see the list of subtitles available with this:
Not sure if changes should or can be made here to remove the unwanted captions.
Any help is appreciated, thank you.
The text was updated successfully, but these errors were encountered: