Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSAN: Generate TSAN clang rt libs for riscv64 #104

Closed
prashanthswami opened this issue Jul 14, 2023 · 7 comments
Closed

TSAN: Generate TSAN clang rt libs for riscv64 #104

prashanthswami opened this issue Jul 14, 2023 · 7 comments
Assignees

Comments

@prashanthswami
Copy link
Collaborator

To be at parity with other architectures in the Android NDK, we would like to have the libclang_rt.tsan-riscv64-android.so library included as part of the imported sysroot from Android (Clang Prebuilts). This is distinct from it actually working, which is tracked here: android/ndk#1041 .

@pirama-arumuga-nainar
Copy link
Collaborator

https://reviews.llvm.org/D145214 enables tsan runtime for riscv64.

@enh-google
Copy link
Collaborator

seems like no-one's reviewed that change yet. @appujee --- is that something we can help with?

@appujee
Copy link
Collaborator

appujee commented Sep 13, 2023

let me reach out to the author if he is still working on it.

@appujee
Copy link
Collaborator

appujee commented Sep 14, 2023

nobody responded to my query on discord. I can commandeer the patch and put for review.

@appujee
Copy link
Collaborator

appujee commented Sep 18, 2023

Update: The author is waiting on review as the patch is feature complete. I've pinged the reviewers

@appujee
Copy link
Collaborator

appujee commented Sep 28, 2023

Update: I pinged reviewers to take another look.
Except for minor nits, the reviewers are okay with the patch but would like dvyukov to take a look. I've pinged him.

@appujee
Copy link
Collaborator

appujee commented Oct 13, 2023

Merged.
llvm/llvm-project#68735
I tested it on licheepi board as well.

@appujee appujee closed this as completed Oct 13, 2023
@appujee appujee self-assigned this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants