Ghidra does not set FlowGraph.Edge.is_back_edge used to indicate loops

[mr-tz]

I think this should happen in this function:

binexport/java/src/main/java/com/google/security/binexport/BinExport2Builder.java

Line 324 in e5199d7

private void buildFlowGraphs(Map<Long, Integer> basicBlockIndices) throws CancelledException {

Related function for IDA:

binexport/binexport2_writer.cc

Line 372 in e5199d7

void WriteFlowGraphs(const FlowGraph& flow_graph, BinExport2* proto) {

[mike-hunhoff]

@cblichmann can you clarify what is responsible for setting back edges? My understanding is that the underlying disassembler (IDA, Ghidra, etc.) builds a flow graph from which BinExport core uses https://github.com/google/binexport/blob/main/function.h#L72 to calculate back edges? If my understanding is correct, then it may be that the Ghidra extension is not generating flow graphs correctly (or at least this would be a good place to start before digging into BinExport core).