Skip to content
This repository has been archived by the owner on Dec 10, 2022. It is now read-only.

Remove eval() use in BlockEditor #114

Open
chynu opened this issue Jul 18, 2017 · 2 comments
Open

Remove eval() use in BlockEditor #114

chynu opened this issue Jul 18, 2017 · 2 comments

Comments

@chynu
Copy link
Contributor

chynu commented Jul 18, 2017

The updatePreview() function under block_editor_controller.js uses eval() to evaluate manually inputted block definitions in order to display the user-defined blocks in the preview. Remove the use of eval() in parsing and displaying user-inputted block definitions.

@chynu chynu changed the title Remove eval() use in BlockFactory Remove eval() use in BlockEditor Jul 18, 2017
@AnmAtAnm
Copy link
Contributor

AnmAtAnm commented Aug 3, 2017

Potential solution would be to use JSInterpreter. This would require wrapping a whole lot of functions to support the majority of Blockly blocks. It would also take a significant test infrastructure to verify.

@AnmAtAnm
Copy link
Contributor

See temporary solution in google/blockly#1235.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants