Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turtle field demo calls deprecated getColourShadow #606

Closed
moniika opened this issue Mar 24, 2021 · 0 comments · Fixed by #790
Closed

turtle field demo calls deprecated getColourShadow #606

moniika opened this issue Mar 24, 2021 · 0 comments · Fixed by #790
Labels
category: example Anything in the examples folder cleanup good first issue Good for newcomers help wanted Open for contributions type: bug Something isn't working

Comments

@moniika
Copy link
Contributor

moniika commented Mar 24, 2021

Category

Examples

Component

turtle-field-demo

Describe the bug

Field calls deprecated method, triggering warning.

To Reproduce

Steps to reproduce the behavior:

  1. Run the demo
  2. Click on "toggle shadow" button
  3. Observe warning in console:
BlockSvg.prototype.getColourShadow was deprecated on January 2020 and will be deleted on January 2021.
Use style.colourSecondary instead.
Blockly.utils.deprecation.warn @ deprecation.js:33
Blockly.BlockSvg.getColourShadow @ block_svg.js:264
CustomFields.FieldTurtle.applyColour @ field_turtle.js:471
Blockly.BlockSvg.applyColour @ block_svg.js:987
Blockly.BlockSvg.setShadow @ block_svg.js:863
toggleShadow @ index.html?_ijt=t5dmqamc036d4ti944cleeam4c:111
onclick @ index.html?_ijt=t5dmqamc036d4ti944cleeam4c:57
  1. Click on "toggle enabled" button
  2. Observe warning in console:
deprecation.js:33 BlockSvg.prototype.getColourShadow was deprecated on January 2020 and will be deleted on January 2021.
Use style.colourSecondary instead.
Blockly.utils.deprecation.warn @ deprecation.js:33
Blockly.BlockSvg.getColourShadow @ block_svg.js:264
CustomFields.FieldTurtle.applyColour @ field_turtle.js:471
Blockly.BlockSvg.applyColour @ block_svg.js:987
Blockly.BlockSvg.updateDisabled @ block_svg.js:997
Blockly.BlockSvg.setEnabled @ block_svg.js:1166
toggleEnabled @ index.html?_ijt=t5dmqamc036d4ti944cleeam4c:118
onclick @ index.html?_ijt=t5dmqamc036d4ti944cleeam4c:58

Expected behavior

No warnings.

@moniika moniika added type: bug Something isn't working triage category: example Anything in the examples folder help wanted Open for contributions and removed triage labels Mar 24, 2021
@rachel-fenichel rachel-fenichel added the good first issue Good for newcomers label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: example Anything in the examples folder cleanup good first issue Good for newcomers help wanted Open for contributions type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants