Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release beta version of all plugins #919

Closed
4 tasks done
maribethb opened this issue Oct 15, 2021 · 3 comments
Closed
4 tasks done

Release beta version of all plugins #919

maribethb opened this issue Oct 15, 2021 · 3 comments
Labels
type: bug Something isn't working
Milestone

Comments

@maribethb
Copy link
Contributor

We have the next major release of blockly in beta right now. However, most of the plugins have not yet been updated to be compatible with that version. Anyone who is using any plugins will not be able to cleanly use blockly@beta until they can also use beta versions of the plugins that are listed as compatible with the beta. The issue is the peerDependencies for each plugin specify a version of Blockly that does not include the beta, so npm install will fail as the peer dependencies are not met. See https://groups.google.com/g/blockly/c/MpMkF-hgloA for more context.

The following bugs need to be resolved before this is possible:

Note that the following plugins have already been released as beta versions. If a project depends only on plugins listed below, then these dependencies are already compatible with blockly@beta.

  • block-test
  • eslint-config
  • dev-scripts
  • dev-tools
  • theme-dark
  • theme-deuteranopia
  • theme-highcontrast
  • theme-tritanopia

(If you are wondering how this list was derived, it is all of the plugins that dev-tools rely on that also rely on blockly, plus the plugins related to eslint)

@maribethb maribethb added type: bug Something isn't working triage labels Oct 15, 2021
@maribethb
Copy link
Contributor Author

Note that for the plugins that have already been released as beta, that was done by hand and not with Lerna. If we run into lerna having version issues next time we use it, it's almost certainly because of this, but I don't think there was a way around it since not all of the packages were ready to publish.

@maribethb
Copy link
Contributor Author

The changes I made locally in order to publish the betas are here: https://github.com/google/blockly-samples/compare/2021_q4_release...maribethb:release-beta?expand=1

tbh I'm not sure whether we want to commit these to the repo or let lerna do it when we're ready to release all of them, so I'm just leaving this here so I can decide later.

@maribethb
Copy link
Contributor Author

All plugins have now been released (not as beta) so this is irrelevant now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant