Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the "FinishedLoading" event be added to Events.fromJson? #2250

Closed
BeksOmega opened this issue Feb 1, 2019 · 2 comments
Closed

Should the "FinishedLoading" event be added to Events.fromJson? #2250

BeksOmega opened this issue Feb 1, 2019 · 2 comments

Comments

@BeksOmega
Copy link
Collaborator

I was doing some poking around in the events files working on a different issue, and I noticed the Blockly.Events.fromJson function. Would it make sense for the FinishedLoading event to be added to this? I wasn't sure since the FinishedLoading event is basically a notification about a specific workspace, and the fromJson function takes in a workspace that is then "applied" to the event.

@AnmAtAnm
Copy link
Contributor

AnmAtAnm commented Feb 5, 2019

As far as Blockly code is considered, loading a file is synchronous, so I don't know a case where an outside event is needed. Can you provide a use case that doesn't involve some outside code loading a file asynchronously? (In that case, the outside code should generate it own event in its own event framework.)

@RoboErikG
Copy link
Contributor

For reference this is about #2142 . Going to close this and move the discussion back to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants