Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript typings for generators #2995

Closed
samelhusseini opened this issue Sep 10, 2019 · 2 comments
Closed

Add Typescript typings for generators #2995

samelhusseini opened this issue Sep 10, 2019 · 2 comments
Labels
component: TypeScript issue: feature request Describes a new feature and why it should be added
Milestone

Comments

@samelhusseini
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Include Typescript definitions for Blockly generators.

Describe the solution you'd like

scan the generator directory as part of the typescript definition generation:
https://github.com/google/blockly/tree/master/generators

Feature requested on forums:
https://groups.google.com/forum/#!topic/blockly/Su046eekUZY

@samelhusseini samelhusseini added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Sep 10, 2019
@samelhusseini samelhusseini self-assigned this Sep 10, 2019
@moniika moniika removed the issue: triage Issues awaiting triage by a Blockly team member label Sep 10, 2019
@moniika moniika added this to the Bug Bash Backlog milestone Sep 10, 2019
@aabounegm
Copy link

Any updates on this? I wrote the following workaround in my project:

declare module 'blockly/javascript' {
    import { Generator } from 'blockly';
    const instance: Generator;
    export = instance;
}

but that still doesn't give it the additional properties defined on the Blockly.JavaScript object (which I also can't use because typescript screams that Property 'Javascript' does not exist on type 'typeof Blockly')

@cpcallen
Copy link
Contributor

This was fixed by all the work done to convert the generators to TypeScript (see issue #6828).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: TypeScript issue: feature request Describes a new feature and why it should be added
Projects
None yet
Development

No branches or pull requests

5 participants