-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsed blocks do not update when modified #3784
Comments
Yes, we're interested in a fix. @moniika who has looked into a variety of related rendering issues to discuss and review the associated PR. |
+1 would love fix. |
@moniika Does the solution in the other PR look good to you? I wasn't sure how you guys would feel about the I just wanna check before I start trying to update it. Totally cool with whatever you guys decide. |
I'll take a closer look at that and give you a reply by end of day. |
I'm not really a fan of the isRendering flag. I think we could avoid the recursive calls by updating the collapsed block text without appending field. I tried frankenstein-ing something based on your appinventor changes in #3799 and it seems to fix variables and procedure issue, but I haven't done very extensive edge case testing. Maybe we could do something similar? |
@moniika From my reading it does indeed look like that solves the variable problem. But I think there might be some other areas that need addressing. For example, adding inputs to a collapsed block can look pretty derpy: Do you think your solution could be expanded to handle those cases? My comment here also brings up some alternative solutions. |
After taking a look at your comment over on the other PR, I see why you're using So I'm okay with having a flag. I prefer calling it @moniika and I discussed offline as well. |
Sounds good @rachel-fenichel @moniika I'll work on getting a draft up and running. Know that I'm cool throwing it out if we come up with something better. |
Looks like this has been fixed. |
Describe the bug
Collapsed blocks do not update when they are modified. This includes:
This affects all collapsed blocks, not just the examples below.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Collapsed blocks should update.
Screenshots
Additional context
I fixed this in AppInventor's repo in mit-cml/appinventor-sources#2074
Here is the description of that pull request:
I think the same strategy could work in Core as well. I would be happy to put up a pull request if you are interested.
The text was updated successfully, but these errors were encountered: