Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse context menu option does not group events #5436

Closed
BeksOmega opened this issue Sep 7, 2021 · 0 comments
Closed

Collapse context menu option does not group events #5436

BeksOmega opened this issue Sep 7, 2021 · 0 comments
Labels
component: events help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong

Comments

@BeksOmega
Copy link
Collaborator

Describe the bug

When you select the "Collapse Blocks" context menu option, all of the blocks are properly collapsed. However, if you try to undo this, you have to undo collapsing each block individually, because the events are not grouped.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the playground.
  2. Select the spawn random blocks action, or drag some blocks into the workspace.
  3. Right click the workspace and select the "Collapse Blocks" option.
  4. Attempt to undo the action using ctrl + z
  5. Observe how you have to undo the actions individually.

Additional context

The relevant code of this context menu item lives here.

I think the easiest way to solve this is to remove the timeout, and add setGroup calls surrounding the for-loop.

@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited labels Sep 7, 2021
@BeksOmega BeksOmega added this to the Bug Bash Backlog milestone Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: events help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

2 participants