Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Procedure parameter edits do not get grouped #5439

Closed
BeksOmega opened this issue Sep 7, 2021 · 0 comments
Closed

Procedure parameter edits do not get grouped #5439

BeksOmega opened this issue Sep 7, 2021 · 0 comments

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Sep 7, 2021

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Go to the playground
  2. Drag out a procedure block
  3. Add a parameter
  4. Edit its name
  5. Hit ctrl + z repeatedly.
  6. Observe how the first few triggers don't do anything, and then every other trigger will remove a letter

[Edit]
The first few undos are undoing variable create events. If you stop undoing before you start removing letters, you end up with erroneous variables in the toolbox.

Expected behavior

The entire edit is undone with one trigger.

Additional context

This exists on master and develop, even though text-input fields now group edits on develop. I think change events are probably messing things up.

@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Sep 7, 2021
@gonfunko gonfunko added component: events component: fields component: variables and removed issue: triage Issues awaiting triage by a Blockly team member labels Sep 10, 2021
@gonfunko gonfunko added this to the Bug Bash Backlog milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants