Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multiline field not correctly size in parent block when copy/paste or load. #6461

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

yamadayutaka
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Proposed Changes

Changing size calculation in updateSize_ from getTextWidth to getFastTextWidth.

Behavior Before Change

Multiline field not correctly size in parent block when copy/paste or load.

Behavior After Change

Multiline field correctly size in parent block when copy/paste or load.

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you for trying the alternate approach =)

I need to circle back with the core team on whether we're merging this into the v9 release or saving it for the next one. But I should be able to get back to you soon on that =)

Thank you again! This looks great!

@BeksOmega
Copy link
Collaborator

Going to go ahead and merge this, so it should go out with v9 =) Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants