Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Update deprecations for the new release. #6470

Merged
merged 8 commits into from
Oct 3, 2022

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

N/A

Proposed Changes

  • Removes deprecated things we said we would remove.
  • Updates some deprecation warnings to be removed in the next major.
  • Adds @deprecated tags to some functions that did not have them.

Behavior Before Change

Some functions existed.

Behavior After Change

Now those functions do not exist.

Reason for Changes

Code health.

Test Coverage

N/A

Documentation

N/A

Additional Information

For any breakages due to the removal of deprecated methods, please refer to the deprecation tag, and/or deprecation warning in the code below.

@BeksOmega BeksOmega requested a review from a team as a code owner October 3, 2022 18:02
@BeksOmega BeksOmega requested a review from gonfunko October 3, 2022 18:02
@BeksOmega BeksOmega merged commit d3447ea into google:develop Oct 3, 2022
@BeksOmega BeksOmega deleted the fix/deprecations branch October 4, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants