We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockRendering.Types
Currently the Types object has a bunch of methods like isField, isIcon, isInput, etc, which all return numbers, which are then used as predicates.
Types
isField
isIcon
isInput
We should change these to be type guards so that we can elliminate explicit casts within the rendering code. E.g: https://github.com/BeksOmega/blockly/blob/4cd3e0466003dcc15b2cd6355354fed3575031b9/core/renderers/common/drawer.ts#L287
N/A
No response
The text was updated successfully, but these errors were encountered:
Hey @BeksOmega, can I work on this?
Sorry, something went wrong.
@maribethb
No branches or pull requests
Check for duplicates
Description
Currently the
Types
object has a bunch of methods likeisField
,isIcon
,isInput
, etc, which all return numbers, which are then used as predicates.We should change these to be type guards so that we can elliminate explicit casts within the rendering code. E.g: https://github.com/BeksOmega/blockly/blob/4cd3e0466003dcc15b2cd6355354fed3575031b9/core/renderers/common/drawer.ts#L287
Reproduction steps
N/A
Stack trace
Screenshots
N/A
Browsers
No response
The text was updated successfully, but these errors were encountered: