Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging stack out of function input list doesn't remove all inputs #7381

Closed
1 task done
johnnesky opened this issue Aug 12, 2023 · 2 comments
Closed
1 task done

Dragging stack out of function input list doesn't remove all inputs #7381

johnnesky opened this issue Aug 12, 2023 · 2 comments
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@johnnesky
Copy link
Member

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

When you try to drag a stack of function definition inputs out of the input container, some inputs will remain.

Reproduction steps

  1. Go to: https://blockly-demo.appspot.com/static/tests/playgrounds/advanced_playground.html
  2. Drag a new function into the workspace.
  3. Open up the input list editor.
  4. Add at least two inputs to the input list container. ("x" and "y")
  5. Click and drag the first input out from the container, taking the entire stack of inputs with it.
  6. At least one copy of the "x" input still remains in the container, in addition to the dragged stack!
  7. You can drag the original stack back into the list of inputs and repeat the process to rapidly double the number of copies of the first input.
  8. If the current inputs include "y" and "z" but no "x", and you drag the entire stack away, the remaining inputs will include "x" even though it wasn't previously included.
  9. Find a large stack of inputs that are not attached to the container, and try dragging from the middle of the stack. A similar phenomenon will leave junk inputs attached to the stack.
  10. Sometimes I can remove a chunk of inputs from a stack at a time, but usually all but one of the removed inputs is replaced with an "x" input.

Stack trace

No response

Screenshots

image

Browsers

No response

@johnnesky johnnesky added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Aug 12, 2023
@laurensvalk
Copy link
Contributor

Can confirm. Here is a video of some of the scenarios described above.

update-2023-08-12_13.31.17.mp4

@johnnesky
Copy link
Member Author

Confirmed that this is fixed now, thanks to #7384

@cpcallen cpcallen removed the issue: triage Issues awaiting triage by a Blockly team member label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

3 participants