You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched for similar issues before opening a new one.
Problem
The CodeGenerator class doesn't work as is. You either need to subclass it to define methods like quote_ and scrub_, or you need to cludge onto an instance (which we should not be encouraging).
Request
As such we should make CodeGenerator abstract.
Alternatives considered
No response
Additional context
We want to hold off on doing this until we are ready to publish the correct types for generators. (Or at least until we finish refactoring the API of CodeGenerator).
The text was updated successfully, but these errors were encountered:
Check for duplicates
Problem
The
CodeGenerator
class doesn't work as is. You either need to subclass it to define methods likequote_
andscrub_
, or you need to cludge onto an instance (which we should not be encouraging).Request
As such we should make
CodeGenerator
abstract.Alternatives considered
No response
Additional context
We want to hold off on doing this until we are ready to publish the correct types for generators. (Or at least until we finish refactoring the API of
CodeGenerator
).The text was updated successfully, but these errors were encountered: