Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the blocklyTreeRowContentContainer div #8346

Open
BeksOmega opened this issue Jul 12, 2024 · 3 comments
Open

Delete the blocklyTreeRowContentContainer div #8346

BeksOmega opened this issue Jul 12, 2024 · 3 comments
Labels
issue: bug Describes why the code or behaviour is wrong
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

Remove the rowContents_ div from the toolbox category. Afaict it doesn't actually do anything because its its only styling and doesn't have any styling.

This is still a breaking change though because folks may be relying on this for styling or in downstream category classes.
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited good first issue labels Jul 12, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 12, 2024
@BeksOmega BeksOmega removed help wanted External contributions actively solicited good first issue labels Jul 12, 2024
@deysandip301
Copy link

hey @BeksOmega I would like to work on this issue.
can you please assing this issue to me ??

@BeksOmega
Copy link
Collaborator Author

Go for it @deysandip301 =) Let me know if you have any questions!

@deysandip301 deysandip301 mentioned this issue Jul 16, 2024
Closed
1 task
@deysandip301
Copy link

Hey @BeksOmega I have raised the pull request for this issue
Please review the PR and feel free to give any feedback...
I am looking forward to contribute more .....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
v12
Development

Successfully merging a pull request may close this issue.

fix!: removed redundant blockyTreeRowContentContainer div deysandip301/blockly
2 participants
@BeksOmega @deysandip301