Skip to content
This repository was archived by the owner on May 25, 2022. It is now read-only.

Commit 37c5781

Browse files
authored
Merge pull request #29 from davidmorgan/fix-maps
Fix issue with BuiltMap deserialization. Add test.
2 parents 4781829 + 7f7ae86 commit 37c5781

File tree

12 files changed

+239
-11
lines changed

12 files changed

+239
-11
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## 0.1.2
4+
5+
- Fix issue with BuiltMap deserialization.
6+
37
## 0.1.1
48

59
- Fix error in pubspec.yaml.

built_json/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: built_json
2-
version: 0.1.1
2+
version: 0.1.2
33
description: >
44
JSON serialization for Built Collections, Built Values and Enum Classes.
55
This library is the runtime dependency.

built_json_generator/lib/src/source_field.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ abstract class SourceField implements Built<SourceField, SourceFieldBuilder> {
1414
static final BuiltMap<String, String> typesWithBuilder =
1515
new BuiltMap<String, String>({
1616
'BuiltList': 'ListBuilder',
17-
'BuiltMap': 'MapBuiler',
17+
'BuiltMap': 'MapBuilder',
1818
'BuiltSet': 'SetBuilder',
1919
});
2020

built_json_generator/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: built_json_generator
2-
version: 0.1.1
2+
version: 0.1.2
33
description: >
44
JSON serialization for Built Collections, Built Values and Enum Classes.
55
This library is the dev dependency.
@@ -14,7 +14,7 @@ dependencies:
1414
analyzer: '>=0.27.1 <0.28.0'
1515
build: '^0.3.0'
1616
built_collection: '^1.0.1'
17-
built_json: '^0.1.0'
17+
built_json: '^0.1.2'
1818
source_gen: '>=0.5.0 <0.6.0'
1919
quiver: '>=0.21.0 <0.22.0'
2020

example/lib/collections.dart

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
// Copyright (c) 2016, Google Inc. Please see the AUTHORS file for details.
2+
// All rights reserved. Use of this source code is governed by a BSD-style
3+
// license that can be found in the LICENSE file.
4+
5+
library collections;
6+
7+
import 'package:built_collection/built_collection.dart';
8+
import 'package:built_json/built_json.dart';
9+
import 'package:built_value/built_value.dart';
10+
11+
part 'collections.g.dart';
12+
13+
/// Example built_value type containing collections.
14+
abstract class Collections
15+
implements Built<Collections, CollectionsBuilder> {
16+
/// Example of how to make a built_value type serializable.
17+
///
18+
/// Declare a static final [Serializers] field called `serializer`.
19+
/// The built_json code generator will provide the implementation. You need to
20+
/// do this for every type you want to serialize.
21+
static final Serializer<Collections> serializer = _$collectionsSerializer;
22+
23+
BuiltList<String> get list;
24+
BuiltSet<int> get set;
25+
BuiltMap<String, int> get map;
26+
27+
Collections._();
28+
factory Collections([updates(CollectionsBuilder b)]) = _$Collections;
29+
}
30+
31+
/// Builder class for [Collections].
32+
abstract class CollectionsBuilder
33+
implements Builder<Collections, CollectionsBuilder> {
34+
ListBuilder<String> list = new ListBuilder<String>();
35+
SetBuilder<int> set = new SetBuilder<int>();
36+
MapBuilder<String, int> map = new MapBuilder<String, int>();
37+
38+
CollectionsBuilder._();
39+
factory CollectionsBuilder() = _$CollectionsBuilder;
40+
}

example/lib/collections.g.dart

Lines changed: 133 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/lib/has_int.g.dart

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/lib/serializers.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ library serializers;
66

77
import 'package:built_collection/built_collection.dart';
88
import 'package:built_json/built_json.dart';
9+
import 'package:example/collections.dart';
910
import 'package:example/compound_value.dart';
1011
import 'package:example/has_int.dart';
1112
import 'package:example/test_enum.dart';

example/lib/serializers.g.dart

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/lib/test_enum.g.dart

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)