New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable static analysis for build tags on tests. #163

Closed

ralimi opened this issue Sep 3, 2023 · 0 comments · Fixed by #197

Collaborator

ralimi commented Sep 3, 2023

The migration to bzlmod in #162 left nogo unsupported. See bazel-contrib/rules_go#3529 for context.

We have a static analysis tool that ensures there are no Go buildtags specified in _test.go files. Including such tags can silently prevent tests from running. See https://github.com/google/chrome-ssh-agent/tree/master/nogo/testbuildtags for the code.

This issue tracks finding a way to re-enable these static analysis checks.

ralimi mentioned this issue

Migrate to bzlmod #162

Merged

ralimi mentioned this issue

Revert to nogo instead of golangci-lint #197

Merged

ralimi closed this as completed in #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment