Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getProjectSettings async #146

Closed
grant opened this issue Apr 26, 2018 · 1 comment
Closed

Make getProjectSettings async #146

grant opened this issue Apr 26, 2018 · 1 comment

Comments

@grant
Copy link
Contributor

grant commented Apr 26, 2018

getProjectSettings should be async to reduce nesting.

Expected Behavior

let { scriptId, rootDir } = await getProjectSettings();
// ...

Actual Behavior

getProjectSettings().then(({ scriptId, rootDir }: ProjectSettings) => {
  // ...
});
@grant grant mentioned this issue Apr 26, 2018
Merged
3 tasks
@campionfellin campionfellin mentioned this issue Apr 27, 2018
Merged
3 tasks
@grant
Copy link
Contributor Author

grant commented May 22, 2018

Fixed with #152.

@grant grant closed this as completed May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grant