Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Commit 1bcb6b0

Browse files
nreid260shicks
authored andcommitted
Suppress some type errors uncovered by an upcoming JSCompiler change CL/265147914.
The change improves modeling of template types and substitution. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=265600884
1 parent 1635e05 commit 1bcb6b0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

closure/goog/testing/testcase.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,14 @@ goog.testing.TestCase = function(opt_name) {
162162
* <li>[1,3,5]
163163
* <li>[testName1, testName2, 3, 5] - will work
164164
* <ul>
165-
* @type {Object}
165+
* @type {?Object}
166166
* @private
167167
*/
168168
this.testsToRun_ = null;
169169

170170
/**
171171
* A call back for each test.
172-
* @private {?function(goog.testing.TestCase.Test, !Array<string>)}
172+
* @private {?function(?goog.testing.TestCase.Test, !Array<string>)}
173173
*/
174174
this.testDone_ = null;
175175

@@ -1446,6 +1446,7 @@ goog.testing.TestCase.prototype.addTestObj_ = function(obj, name, objChain) {
14461446
} else if (goog.isObject(testProperty)) {
14471447
// To prevent infinite loops.
14481448
if (!goog.array.contains(objChain, testProperty)) {
1449+
goog.asserts.assertObject(testProperty);
14491450
var newObjChain = objChain.slice();
14501451
newObjChain.push(testProperty);
14511452
this.addTestObj_(testProperty, fullTestName, newObjChain);

0 commit comments

Comments
 (0)