Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26.3.2 Deriving Error enums #1285

Closed
mgeisler opened this issue Oct 2, 2023 Discussed in #1281 · 1 comment · Fixed by #2332
Closed

26.3.2 Deriving Error enums #1285

mgeisler opened this issue Oct 2, 2023 Discussed in #1281 · 1 comment · Fixed by #2332
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mgeisler
Copy link
Collaborator

mgeisler commented Oct 2, 2023

Discussed in #1281

Originally posted by njr0 September 29, 2023
I think a little but more explanation would be helpful here.

I don't think the course has mentioned positional arguments to format strings before, and though I think people will guess that's what "{0}" is, it's not immedately apparent, looking at the code, that there's a argument for it to format.

Similarly, I think a few words about #[error and #[from might be useful.

@mgeisler mgeisler added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 2, 2023
@fw-immunant
Copy link
Collaborator

See #2027.

@fw-immunant fw-immunant self-assigned this Aug 12, 2024
@fw-immunant fw-immunant linked a pull request Aug 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants