Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dprint fmt failing #2165

Closed
djmitche opened this issue Jun 24, 2024 · 2 comments · Fixed by #2168
Closed

dprint fmt failing #2165

djmitche opened this issue Jun 24, 2024 · 2 comments · Fixed by #2168

Comments

@djmitche
Copy link
Collaborator

Run dprint/check@v2.2
Run curl -fsSL https://dprint.dev/install.sh | sh -s  > /dev/null 2>&1
Run ~/.dprint/bin/dprint check
Compiling https://plugins.dprint.dev/json-0.17.4.wasm
Compiling https://plugins.dprint.dev/toml-0.[5](https://github.com/google/comprehensive-rust/actions/runs/9638343597/job/26600420163#step:5:6).4.wasm
Compiling https://plugins.dprint.dev/markdown-0.16.2.wasm
from /home/runner/work/comprehensive-rust/comprehensive-rust/src/user-defined-types/static.md:
 8  8| therefore·will·not·move:
 9  9| 
10 10| ```rust,editable
11 11|+rewriting·static
12 11| static·BANNER:·&str·=·"Welcome·to·RustOS·3.14";
13 12| 
14 13| fn·main()·{
--

etc.

This looks like a debug print, but I don't see that in any of the dprint repos. It doesn't reproduce locally. If I remove ~/.cache/dprint, I get other errors, in formatting of the .po files, but not these errors (I'll make a PR for that).

dprint.json suggests it's running nightly rustfmt for Rust stuff, so perhaps that's responsible? Indeed, rust-lang/rustfmt#6213.

@djmitche
Copy link
Collaborator Author

rust-lang/rustfmt#6210 has a fix, so we might just need to sit on our hands until this filters out.

@mgeisler
Copy link
Collaborator

mgeisler commented Jul 3, 2024

@kdarkhan actually ran into this recently in mdbook-i18n-helpers: google/mdbook-i18n-helpers#205 (comment). We should have made more noise about it so you would have seen it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants