Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Error for CoseError #60

Closed
janosimas opened this issue Dec 19, 2022 · 3 comments
Closed

Implement Error for CoseError #60

janosimas opened this issue Dec 19, 2022 · 3 comments

Comments

@janosimas
Copy link

Is there any reason for CoseError not to implement Error?
This causes issues when working with other libraries, like thiserror
@daviddrysdale
Copy link
Collaborator

The original reason was because this crate is #[no_std], and Error used to be std-only.

AIUI Error has now moved into core, but I guess that would require a suitable MSRV to use.

In the meanwhile, I guess we could add a (non-default) std feature that adds an Error implementation.

@janosimas
Copy link
Author

The std feature looks good to me

@daviddrysdale
Copy link
Collaborator

Fixed in #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daviddrysdale @janosimas