Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong cache detection of old processors #182

Closed
gchatelet opened this issue Oct 20, 2021 · 1 comment · Fixed by #183
Closed

Wrong cache detection of old processors #182

gchatelet opened this issue Oct 20, 2021 · 1 comment · Fixed by #183
Assignees
@gchatelet
Labels
bug Something isn't working
Milestone
v0.7.0

Comments

@gchatelet
Copy link
Collaborator

Old processors -like Pentium 4- provide cache information via descriptors available in cpuid leaf 2.
https://www.felixcloutier.com/x86/cpuid#input-eax-=-02h--tlb-cache-prefetch-information-returned-in-eax--ebx--ecx--edx

On newer processors this information is provided via leaf 0x00000004 for Intel and leaf 0x8000001D for AMD.

Both detection run sequentially. Unfortunately the ParseCacheInfo function overrides the CacheInfo data already setup by ParseLeaf2.
@gchatelet gchatelet added the bug Something isn't working label Oct 20, 2021
@gchatelet gchatelet self-assigned this Oct 20, 2021
@gchatelet gchatelet mentioned this issue Oct 20, 2021
Merged
@gchatelet
Copy link
Collaborator Author

This patch introduced

  • a memory overflow fixed in 7bd206a.
  • a change in behavior fixed in c5659bf.

@Mizux Mizux added this to the v0.7.0 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gchatelet gchatelet

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Fixes wrong cache detection of old processors google/cpu_features
2 participants
@gchatelet @Mizux