Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled Android Proguard rules in 2.15 not taking effect #1091

Closed
krage opened this issue Mar 9, 2018 · 6 comments
Closed

Bundled Android Proguard rules in 2.15 not taking effect #1091

krage opened this issue Mar 9, 2018 · 6 comments

Comments

@krage
Copy link

krage commented Mar 9, 2018

I've had -dontwarn com.google.errorprone.annotations.* in my project's proguard rules for a while now waiting for dagger's consumer rules to be bundled. I saw a related PR was merged for 2.15 so I've tried building without that line in my project's rules and I still get the same handful of "can't find referenced class" errors pointing to that package that I was getting prior to 2.15.

@ronshapiro
Copy link

You're right, I'm not seeing those in the packaged aar. I'll investigate

@ronshapiro
Copy link

Apparently it's not included in the aar in Bazel...

@ronshapiro
Copy link

Here's the issue in Bazel: bazelbuild/bazel#4467

@jaredsburrows
Copy link

@ronshapiro Was this not the correct fix, #1059? Or does bazel have a separate issue on their end?

@ronshapiro
Copy link

That only fixed things for Bazel users. Bazel is not (yet) actually adding it to the aar though (it uses it in its internal implementation)

@ronshapiro
Copy link

This is now in bazel, and at least working in 2.17, possibly 2.16 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants