Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the code #24

Open
1 of 5 tasks
rgayon opened this issue Jun 7, 2018 · 3 comments
Open
1 of 5 tasks

Cleanup the code #24

rgayon opened this issue Jun 7, 2018 · 3 comments

Comments

@rgayon
Copy link
Collaborator

rgayon commented Jun 7, 2018 •
edited
Loading

  • Split tests
  • Make tests docstrings more descriptive
  • Add end to end tests
  • Rename docker_version to storage_version
  • Hardcoded strings in tests should all follow the same format
@rgayon rgayon mentioned this issue Jun 7, 2018
Merged
@rgayon
Copy link
Collaborator Author

rgayon commented Jun 12, 2018

Better raise exceptions on bad containers IDs:
docker_explorer/lib/container.py
IOError: [Errno 2] No such file or directory: u'/9960bc8da09dec5971de847a48b2522c60d47fd172b0075c428408f672b1e85d/config.v2.json'

@rgayon rgayon mentioned this issue Dec 27, 2018
Merged
@rgayon
Copy link
Collaborator Author

rgayon commented Apr 9, 2019

Check why pylint doesn't catch attributes not declared in init

@rgayon
Copy link
Collaborator Author

rgayon commented Apr 16, 2019

Now has even more end2end tests, running on Jenkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rgayon