Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] Row/col formatting breaks Docsy components #1466

Closed
7 tasks done
Tracked by #470
chalin opened this issue Mar 8, 2023 · 1 comment · Fixed by #1523
Closed
7 tasks done
Tracked by #470

[BSv5] Row/col formatting breaks Docsy components #1466

chalin opened this issue Mar 8, 2023 · 1 comment · Fixed by #1523
Assignees

Comments

@chalin
Copy link
Collaborator

chalin commented Mar 8, 2023

Formatting of rows and columns has changed in BSv5, in particular:

  • There seems to be an (not-explicitly documented) assumption that a row's child is meant to be a col. And a row's child is now set at width and max-width of 100%. This breaks the layout of several components in Docsy, like blocks/* and page footer.
  • Why flex-shrink 0 for all columns? twbs/bootstrap#37951

Tasks:

@chalin
Copy link
Collaborator Author

chalin commented Mar 9, 2023

I've searched for .row and ensured that the immediate children elements are columns. I think that all cases have been covered. The only exception is the footer, which I can't get to work other than how it was setup via #1373. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant