Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile view with the sidebar search disabled #211

Closed
tshort opened this issue Feb 22, 2020 · 6 comments
Closed

Mobile view with the sidebar search disabled #211

tshort opened this issue Feb 22, 2020 · 6 comments

Comments

@tshort
Copy link

tshort commented Feb 22, 2020

With sidebar_search_disable = true, the mobile view loses the search bar and the navigation icon. The navigation icon is most important.

In Lunr and Algolia, the sidebar isn't supported, so this is probably a common setup.

Any suggestions on how to improve the mobile view?

@LisaFC
Copy link
Collaborator

LisaFC commented Feb 24, 2020

Just FYI sidebar search is now supported with Lunr, but yes, agree we need to make sure we provide a good experience on mobile without it.

If you have one handy, do you have an example of a site without a sidebar search so I can see what it looks like in Mobile? Otherwise I'll spin one up myself when I have a moment. I don't think we intended for the nav icon to disappear as well but that is not to say that's not what happens. :)

@tshort
Copy link
Author

tshort commented Feb 24, 2020

Sorry, I don’t have a public site with the sidebar disabled.

@LisaFC
Copy link
Collaborator

LisaFC commented Feb 26, 2020

No problem, I can put together a little demo and see what I can fix!

@LisaFC
Copy link
Collaborator

LisaFC commented Feb 26, 2020

Yep, you're right, the navigation isn't appearing, I'll try to fix that.

@frodriguezsmartclip
Copy link

I suscribe to this thread, I need this too. Thanks @LisaFC 😉

@LisaFC
Copy link
Collaborator

LisaFC commented Jul 1, 2020

Fixed in #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants