-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown table rendering doesn't occur inside folding summary #883
Comments
Can you paste in the source and hopefully I can see what's going on? Markdown + CSS has many weirdnesses, it may just need some more specific styling provided. |
Hi there, @LisaFC . Sure. First table is just in a "clean" Markdown seaction:
Second one is inside a folding block (I really don't know the correct terminology here):
*I added backslashes in front of the code block fencing around the ClusterPolicy to try and escape the outer code block GitHub is providing. |
And here's the live site where you can see how this is rendering yourself: https://kyverno.io/docs/writing-policies/jmespath/ |
Right, as I suspected, it's a CSS thing - a table inside a division doesn't get the default table styling from our stylesheets applied to it. Let me see if I can tweak it so that it formats correctly - is there any situation where you wouldn't want a table inside another element to have our default styling? |
Not that I can think of. |
Hey @LisaFC and Docsy team, just following up on this issue! |
@chipzoller There's a PR with a fix for that issue (#1017), likely to be included in the next release. |
Thank you very much! |
@chipzoller @geriom @LisaFC - I believe that #1255 closes this issue. WDYT? |
Yes, confirmed resolved. Thank you to everyone! |
Probably not using the right terms, but if you nest a Markdown table inside a folding/summary block, the table doesn't get rendered. Searched and didn't see an issue (open or closed) which references this. Also on an older version of Docsy so maybe this has already been addressed. Here's what this looks like when you compare a rendered table to a non-rendered table inside one of these folding/summary blocks:
Good
![image](https://user-images.githubusercontent.com/29008123/153017751-5ef38e6d-d4f5-4a41-af83-54b41be486f4.png)
Bad
![image](https://user-images.githubusercontent.com/29008123/153017801-be8c401e-c493-4b33-b61d-28aaae3d6b98.png)
The text was updated successfully, but these errors were encountered: