Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use batchSize parameter #1192

Open
LJNIC opened this issue Sep 19, 2024 · 1 comment
Open

Use batchSize parameter #1192

LJNIC opened this issue Sep 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@LJNIC
Copy link
Contributor

LJNIC commented Sep 19, 2024

Is there a reason the batchSize parameter isn't overrideable via configuration?

@bashir2
Copy link
Collaborator

bashir2 commented Sep 23, 2024

The main reason is that we try to expose minimum number of config params in the controller configuration and we thought batchSize tuning is not that important. That said, there are some recent evidences, like #1104, that contradicts that assumption.

Please feel free to expose this in the controller configuration, if it matters to you (and ideally provide some context/data describing why it matters to you).

@bashir2 bashir2 added the enhancement New feature or request label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants