Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When paging through search Bundles, next URLs are not properly escaped / encoded #1290

Open
lawley opened this issue Feb 6, 2025 · 0 comments
Assignees
Labels
bug Something isn't working P1:must As issue that definitely needs to be implemented in near future.

Comments

@lawley
Copy link

lawley commented Feb 6, 2025

searchByUrl in pipelines/batch/src/main/java/com/google/fhir/analytics/FhirSearchUtil.java fails to %-encode the query parameters in the url String parameter.

If a search result Bundle returns a next page URL, properly %-encoded because, for example, the link include " characters, this is %-decoded (presumably by the HAPI library?) but not subsequently %-encoded before being used in the client.search() invocation.

The result is that resources from such FHIR servers fail to be fetched and loaded.

@bashir2 bashir2 self-assigned this Feb 11, 2025
@bashir2 bashir2 added bug Something isn't working P1:must As issue that definitely needs to be implemented in near future. labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1:must As issue that definitely needs to be implemented in near future.
Projects
None yet
Development

No branches or pull requests

2 participants