Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c# code generation is wrong #5663

Closed
bturner1273 opened this issue Dec 11, 2019 · 5 comments
Closed

c# code generation is wrong #5663

bturner1273 opened this issue Dec 11, 2019 · 5 comments
Labels

Comments

@bturner1273
Copy link

bturner1273 commented Dec 11, 2019

This is flatbuffer (master) running in .net. The code generated by 'flatc --csharp filename.fbs' calls builder.StartObject instead of builder.StartTable causing the code to error out.

please switch to builder.StartTable for code generation

@bturner1273
Copy link
Author

Also if you wanna make a nuget package I think the world would be a happier place

@aardappel
Copy link
Collaborator

Are you sure your flatc and your runtime code come from the same repo? It sounds like you have a version mismatch.

Which indicates exactly the problem with packages: unless flatc can somehow come with the package, it would encourage even more of these version mismatches. The correct way to use FlatBuffers is to ensure all comes from the same repo.

That said, I don't mind supporting nuget. Related: #5620, #4162, #3753

@prat0088
Copy link

prat0088 commented Dec 17, 2019

I encountered an issue, too. I solved it by building flatc from source. Whatever is in v1.11.0 isn't working well in C#. I think cutting a new release and pushing a new version of flatc.exe from head would fix the problem. Haven't verified but that's my recollection from encountering a similar issue many months ago.

Update: The issue I encountered is reported in #5620

@aardappel
Copy link
Collaborator

A new release is forthcoming, but you should never rely on mixing different versions, whether release or not.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants