-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart null safety #6282
Comments
Any plans with this one? |
me too. This is really needed. Protobuf has been upgraded already: https://pub.dev/packages/protobuf |
BTW I've prepared a null-safe version in our ObjectBox fork of FlatBuffers (https://github.com/objectbox/objectbox-dart/tree/main/objectbox/lib/flatbuffers). It includes a lot of performance improvements/fixes, some of which were originally prepared by @mraleph in separate discussions (basically this commit: objectbox/objectbox-dart@a729705#diff-594a84a4fd72af27284e6f59d689b04f9f1f8cfe9dbcdfb512669d16d0f702b0). If the maintainers are open to a PR, I could prepare one, though it's going to be a little large, with all those changes in the meantime. Some changes could be cherry-picked but I'd only like to do that if there's a reasonable chance they're going to get merged upstream (i.e. here). |
@aardappel I would be happy to do the actual code review of @vaind's PR if you need somebody from the Dart background to do that. |
im new in flatbuffers with dart, any news on this ? |
@vaind how do you handle code-generation with your forked version, or is that not handled yet? Do you have a fork of I'm trying to figure out if it's possible for me to generate null-safe dart code using |
@zicklag no, it's currently not supported in flatc - we're using custom code generation specific for objectbox-dart |
Waiting for #6661 to be merged, before going ahead with this PR. |
Any timeline for providing null-safety to the dart package? https://medium.com/dartlang/announcing-dart-null-safety-beta-87610fee6730
The text was updated successfully, but these errors were encountered: