Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NNX _compute_stats function missing use_fast_variance and mask argument #3690

Closed
chiamp opened this issue Feb 12, 2024 · 1 comment · Fixed by #3693
Closed

NNX _compute_stats function missing use_fast_variance and mask argument #3690

chiamp opened this issue Feb 12, 2024 · 1 comment · Fixed by #3693
Assignees
@chiamp

Comments

@chiamp
Copy link
Collaborator

chiamp commented Feb 12, 2024

NNX _compute_stats function is missing use_fast_variance and mask argument, compared to the Linen equivalent. Is this intentional or should we add this into NNX?

cc: @cgarciae
@chiamp chiamp self-assigned this Feb 13, 2024
@cgarciae
Copy link
Collaborator

This is not intentional, most likely it was added after the initial port of the code.
If you can add use_fast_variance it would amazing!

@chiamp chiamp mentioned this issue Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chiamp chiamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated nnx compute_stats chiamp/flax
2 participants
@cgarciae @chiamp