Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no need to measure child when it is GONE #170

Closed
Shuijwan opened this issue Dec 23, 2016 · 4 comments
Closed

no need to measure child when it is GONE #170

Shuijwan opened this issue Dec 23, 2016 · 4 comments
Labels
bug
Milestone
0.3.0

Comments

@Shuijwan
Copy link

Hi, seems there is no need to measure GONE child in stretchViews().
@thagikura
Copy link
Contributor

Thanks for bringing this up!
You are right, it's not needed to measure a view if the view's visibility is GONE in stretchViews.

The fix is already applied to the dev_recyclerview branch, which is going to be merged to master once it gets stable.
So I'll keep this issue open, once it's merged to master, I'll close this.

@thagikura thagikura added the bug label Dec 26, 2016
@thagikura thagikura added this to the 0.3.0 milestone Dec 26, 2016
@Shuijwan
Copy link
Author

Thanks 👍

@isswu
Copy link

isswu commented Jan 23, 2017

Good

@thagikura
Copy link
Contributor

Fixed by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
3 participants
@thagikura @Shuijwan @isswu