Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing the use of FlexLine's top (mTop/getTop()) #244

Closed
eneim opened this issue Mar 31, 2017 · 3 comments
Closed

Confusing the use of FlexLine's top (mTop/getTop()) #244

eneim opened this issue Mar 31, 2017 · 3 comments
Labels
Milestone

Comments

@eneim
Copy link

eneim commented Mar 31, 2017

In my case, FlexLine top is the same for all lines. In fact, it is understandable as the way it was set is as follow:

mTop = Math.min(mTop, view.getTop() - flexItem.getMarginTop() - topDecoration);

So every FlexLine may shares the same Top, which is confused to me (in a Row/Wrap, each line stays beneath other line accept for the one on top, so a line's top should be bigger than the line above it).

Can you enlighten me more about this mTop if possible?

@thagikura
Copy link
Contributor

thagikura commented Mar 31, 2017

I assume you are using FlexboxLayoutManager, instead of FlexboxLayout.

And I realized there is an issue on calculation of that logic..
Since when the user scrolls, layoutFlexLineMainAxis(Horizontal/Vertical) is called only the new line, the coordinates for existing lines are not updated.

Let me either update the existing lines or make FlexboxLayoutManager not support retrieving the flex lines instance.

@thagikura thagikura added the bug label Mar 31, 2017
@eneim
Copy link
Author

eneim commented Mar 31, 2017

@thagikura Ah yes, to confirm your point, it is about FlexboxLayoutManager. Thanks for the response.

@thagikura
Copy link
Contributor

Fixed by #316. Removed the set of methods of retrieving the positions of a flex line.

@thagikura thagikura added this to the 0.3.0 milestone Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants