-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Failed to setup Skia Gr context. #135
Comments
@chinmaygarde This is flutter/engine#6353 right? Do we need to add the resolver callback, or are you going to add fallbacks as discussed in the other bug? |
I am going to add the fallback for OpenGL proc accessors. Though, it is a good idea for embedders to be explicit about the same. I'll submit a patch to both. Sorry about the delay, I thought flutter/engine#6353 was already reverted while I was on vacation. |
This has been patched in the engine (flutter/engine#6523). No changes should necessary for embedders once the updates are pulled in. |
Awesome, thanks! |
This is still broken for me. |
`malkia@penguin:~/p/flutter/bin$ ./flutter doctor -v [✗] Android toolchain - develop for Android devices [!] Android Studio (not installed) [!] VS Code (version 1.28.2) [!] Connected device ! Doctor found issues in 4 categories.` |
malkia@penguin:~/p/flutter-desktop-embedding/example/linux$ ./out/flutter_embedder_example |
malkia@penguin:~/p/flutter-desktop-embedding/example/linux/out$ ldd ./flutter_embedder_example |
I had found that I needed to go into some of the scripts and specify the correct commit hash in order for it to pull in the changes mentioned above. I can check my local repository and see what those changes were once I get to my computer. |
Here is the diff of the file I had to change to make things work:
|
In general, forcing a specific engine version is a bad idea. There can be dependencies between the Flutter tree version and the engine version, which is why there's an auto-roller in Flutter that tests the engine before pulling in a new version. You may have arbitrary problems when using an untested combination. Except in rare cases where you really know what you are doing, the right way to pick up an engine change is to roll your Flutter tree forward to a version whose engine pin has advanced beyond the engine commit you want. (In this case, your hard-coded version is nearly a month behind the version of the engine that @malkia should be using with that Flutter tree, so forcing that version would likely regress something.)
That should definitely have the fix. @malkia, could you check your |
I completely understand, I was just offering a work around that fixed it for me. Thanks for sharing the proper steps to diagnose/solve the issue. |
@stuartmorgan - I have this:
|
That means you do have the correct engine version (unless something went wrong with the update step such that the library didn't get updated, but the version stamp did). I've updated my Linux machine to your exact Flutter version though, and it's working for me. Have you ever had it working on this machine? If not, perhaps your issue isn't related to the resolver change even though the failure mode is the same. (If so, the only other thing I can think to try is a completely clean build in case something is stale and not getting rebuilt.) |
So it could be due to Crostini, that's my Linux on my Chromebook, and AFAIK there is not (yet) real gfx acceleration there. I'll try to install crouton again, and test it out! FYI: I've tried passing --enable-software-rendering, and extending the example to do so - but did nothing. |
I experience this issue when using flutter v1.0 with the latest master for flutter-desktop-embedding. I'm building the example on an up-to-date Ubuntu Bionic. Please let me know when there are any details I may provide or debugging steps to take. |
Perhaps this should be re-opened @stuartmorgan ? |
Please file a new bug; the error message is pretty generic, and can be caused by a variety of issues. The initial bug was 100% reproducible for everyone on Linux because of an engine change that has been fixed. What's happening for some people now is different, even though the final error message is the same, so I'd rather not conflate it with the earlier bug's discussion. |
Seeing this too after a fresh install.
|
Opened #170 since nobody else has opened a new bug. Please use that bug going forward. |
Following the instructions in the README for the example application briefly opens the application, but then yields the following error:
Ubuntu 18.04
The text was updated successfully, but these errors were encountered: