Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build isn't reproducible #206

Closed
ericonr opened this issue Mar 23, 2020 · 2 comments · Fixed by #207
Closed

Build isn't reproducible #206

ericonr opened this issue Mar 23, 2020 · 2 comments · Fixed by #207
Labels

Comments

@ericonr
Copy link

ericonr commented Mar 23, 2020

Hey there!

Several Linux distros (at least Arch, Debian and SUSE) are striving for reproducible builds, as a way to verify build systems and guarantee the legitimacy of build servers and whatnot. The build time injection done in the Makefile makes building fscrypt an unreproducible process.

The Arch Linux PKGBUILD already applies a patch to the Makefile to make it reproducible, and on Debian it's flagged as unreproducible. Fixing this issue upstream is probably the best way of widely making fscrypt a reproducible build.

@josephlr
Copy link
Member

@ericonr, thanks for the report. For the record, I think it should be an explicit goal of fscrypt's development to have a reproducible build. Toward that end, I've opened #207.

PTAL, and let me know if that is not enough to resolve this issue.

@ericonr
Copy link
Author

ericonr commented Mar 24, 2020

Well, that was fast! Thanks for the quick response! This is quite a useful piece of software.

Stay safe!

@ebiggers ebiggers added the bug label Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants