Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glog cmake support in upstream packages #505

Closed
2 tasks
NeroBurner opened this issue Dec 16, 2019 · 0 comments · Fixed by #646
Closed
2 tasks

glog cmake support in upstream packages #505

NeroBurner opened this issue Dec 16, 2019 · 0 comments · Fixed by #646
Milestone
0.5

Comments

@NeroBurner
Copy link
Contributor

NeroBurner commented Dec 16, 2019 •
edited
Loading

Since latest v0.4.0 release glog cmake installation creates a glogConfig.cmake on installation. Unfortunately upstream packages don't yet use the cmake configuration (currently autoconfig is used) and thus no glogConfig.cmake files get generated and installed to

Some Upstream bugs I've found:

This leads to downstream projects needing to provide FindGlog.cmake files
ceres-solver/ceres-solver#535

One show stopper I can think of is the lack of a generated pkgconfig file in v0.4.0 of glog. In current master branch this file is already created. So please make a new release (for example v0.4.1) which adds the pkgconfig file creation to the cmake configuration. I don't think maintainer would update a package to cmake just to loose functionality
@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud mentioned this issue May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

release 0.5 sergiud/glog
2 participants
@sergiud @NeroBurner