Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping autoconf support #537

Closed
sergiud opened this issue Mar 27, 2020 · 4 comments · Fixed by #585
Closed

Dropping autoconf support #537

sergiud opened this issue Mar 27, 2020 · 4 comments · Fixed by #585
Assignees
Milestone

Comments

@sergiud
Copy link
Collaborator

sergiud commented Mar 27, 2020

Currently, glog supports three build systems: autoconf, CMake, and bazel. As autoconf scripts are not actively maintained and CMake can be used as a replacement, I suggest we drop the autoconf support altogether. This would particularly reduce the effort for maintaining the compatibility between autonconf and CMake (and maybe bazel?) scripts.

/cc @ukai @drigz @shinh

@drigz
Copy link
Member

drigz commented Mar 27, 2020

The Bazel build templates the headers based on templates like config.h.cmake.in, logging.h.in, etc. Would these change? For example, logging.h.in refers to @ac_google_end_namespace@ etc - would these be removed / replaced by CMake templates?

If the answer is no, then I think this wouldn't affect the Bazel build. If yes, it should be fairly easy to update the sed duct tape that handles the templating when building with Bazel.

@sergiud
Copy link
Collaborator Author

sergiud commented Mar 27, 2020

Thanks for the info. I thought of keeping placeholder names as is at first. But after seeing the script, we can also update the names to something more readable.

@shinh
Copy link
Collaborator

shinh commented Mar 29, 2020

+1. I was a bit worried this decision may confuse distributions like Debian, however, since I realized gflags has already dropped autotools support, now I'm feeling it's OK.

@sergiud sergiud self-assigned this Apr 6, 2020
@Flamefire
Copy link

For example, logging.h.in refers to @ac_google_end_namespace@ etc - would these be removed / replaced by CMake templates?

Note that @name@ is a perfectly valid template for cmake (configure_file) and even better than the alternative. See @ONLY in the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants