Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPYING file refers to a project via invalid URL #795

Closed
mbrukman opened this issue Feb 20, 2022 · 3 comments
Closed

COPYING file refers to a project via invalid URL #795

mbrukman opened this issue Feb 20, 2022 · 3 comments

Comments

@mbrukman
Copy link
Member

The COPYING file contains the following lines:

glog/COPYING

Lines 31 to 33 in a8e0007

A function gettimeofday in utilities.cc is based on
http://www.google.com/codesearch/p?hl=en#dR3YEbitojA/COPYING&q=GetSystemTimeAsFileTime%20license:bsd

However, this URL is a link to Code Search which is no longer functional, so it returns a 404:

http://www.google.com/codesearch/p?hl=en#dR3YEbitojA/COPYING&q=GetSystemTimeAsFileTime%20license:bsd

Would it be possible to replace it with a direct URL to the original project?

@sergiud
Copy link
Collaborator

sergiud commented Feb 21, 2022

Thanks. Could you submit a PR with the updated URL?

@mbrukman
Copy link
Member Author

@sergiud -- sorry, I don't know what URL that is supposed to point to, otherwise I would have provided an updated URL. The search query is opaque, and as I was not involved in this project early on, I don't know which project this is referring to.

Looks like there's similar text is in the utilities.cc file:

glog/src/utilities.cc

Lines 203 to 204 in a8e0007

// Based on: http://www.google.com/codesearch/p?hl=en#dR3YEbitojA/os_win32.c&q=GetSystemTimeAsFileTime%20license:bsd
// See COPYING for copyright information.

which says this comes from a file named os_win32.c; if we search for that, we find:

so maybe the os_get_time() function is the source of gettimeofday in this repo? Though that's obviously not the original location of that code.

Maybe this is it: https://w1.fi/cgit/hostap/tree/src/utils/os_win32.c#n26 ?

Again, someone more familiar with the history of this project would have to confirm and make the determination; I don't have any insight into this; I just found the above from a little searching and browsing of the code, so it may also be incorrect, as these are just my guesses.

@sergiud
Copy link
Collaborator

sergiud commented Jan 3, 2024

Thanks for the information.

The corresponding code will be replaced by standard functionality in #1020. Therefore, the copyright passage will be removed altogether.

@sergiud sergiud closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants