Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Consider enforcing that all strings are UTF-8 #1281

Closed
vangent opened this issue Feb 8, 2019 · 1 comment
Closed

all: Consider enforcing that all strings are UTF-8 #1281

vangent opened this issue Feb 8, 2019 · 1 comment
Assignees
Milestone

Comments

@vangent
Copy link
Contributor

vangent commented Feb 8, 2019

Per https://github.com/google/go-cloud/blob/master/internal/docs/design.md#strings, Go CDK supports all UTF-8 strings, and drivers are required to do escaping if needed.

Currently, behavior for non-UTF-8 strings is undefined; some providers might error out, others might replace non-UTF-8 characters with unicode.ReplacementChar, etc.

Perhaps we should have the concrete type check for valid UTF-8 strings so we can consistently return an error.

@vangent vangent added this to the Sprint 23 milestone Feb 8, 2019
@vangent vangent self-assigned this Feb 14, 2019
@vangent vangent added the in progress This is being actively worked on label Feb 14, 2019
@vangent
Copy link
Contributor Author

vangent commented Feb 15, 2019

Fixed with #1322.

@vangent vangent closed this as completed Feb 15, 2019
@go-cloud-bot go-cloud-bot bot removed the in progress This is being actively worked on label Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant